Add visualization of rustc span in doc #76668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took me quite some time to figure out what Span::to means. A picture is worth a thousand words.
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pickfire
commented
Sep 13, 2020
| @@ -577,7 +589,13 @@ impl Span { | |||
| ) | |||
| } | |||
|
|
|||
| /// Returns a `Span` between the beginning of `self` to the beginning of `end`. | |||
| /// Returns a `Span` from the beginning of `self` until the beginning of `end`. | |||
There was a problem hiding this comment.
I use the word "until" since the function is call until, more congruence.
|
Nice! @bors r+ rollup |
|
📌 Commit 5dc9790 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
C-cleanup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2020
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#75559 (unions: test move behavior of non-Copy fields) - rust-lang#76441 (Note that parallel-compiler = true causes tests to fail) - rust-lang#76527 (Remove internal and unstable MaybeUninit::UNINIT.) - rust-lang#76629 (Simplify iter zip struct doc) - rust-lang#76640 (Simplify SyncOnceCell's `take` and `drop`.) - rust-lang#76646 (Add mailmap entry) - rust-lang#76651 (Remove Windows details from Unix and VmWorks symlink() docstrings) - rust-lang#76663 (Simplify iter chain struct doc) - rust-lang#76665 (slice::from_raw_parts: explicitly mention that data must be initialized) - rust-lang#76667 (Fix CI LLVM to work on NixOS out of the box) - rust-lang#76668 (Add visualization of rustc span in doc) - rust-lang#76677 (note that test_stable_pointers does not reflect a stable guarantee) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me quite some time to figure out what Span::to means.
A picture is worth a thousand words.